fix: app hangs on starlette when sufficiently many cookies are set #751
Conversation
|
Your Render PR Server URL is https://solara-stable-pr-751.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cr64945ds78s73do2bag. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @iisakkirotko and the rest of your teammates on |
From https://github.com/widgetti/solara/actions/runs/10484645065/job/29169659662?pr=743 I added branch protection so we can auto merge, but that didn't let us do the auto commit. I had to disable it, so the updates ran on master. Maybe that was the same issue? @EwoutH could you try to open a new trivial PR so we can test this? |
In version 13.0 of `websockets`, the environmental variables to configure websockets were renamed (see [here](https://websockets.readthedocs.io/en/stable/project/changelog.html#id2)), which caused apps to hang when running on starlette with more than 8kb of cookies set.
iisakkirotko
force-pushed
the
08-26-ci_automatic_testing_suite_failing
branch
from
36a9641
to
165841b
Compare
iisakkirotko
changed the title
Of course, but I now see CI passing, so is it still needed? Edit: If so, what do I need to do exactly? |
|
Thanks @iisakkirotko ! Sorry, I misunderstoof @EwoutH , it seems 3 (!) related issues were confused in my mind |
Couldn't reproduce locally. Giving ci a shot.